This is a table of the list of TODO used in CLOUDY source files
and the comments following them.
Table from data in 'tabledtodo.txt'
Priority |
Filename |
Line number |
Comment |
0 | conv_base.c | 738 | PvH prefers test against err/10
|
0 | h2.c | 2347 | get better relationship between cr excit of Lya rate
|
0 | hmole_step.c | 4331 | had to comment following test out - NA change to hmole caused
massive prints
|
0 | hydrolevelpop.c | 220 | this does not look right - check logic
|
1 | coolcarb.c | 217 | add neutral helium Staemmler, V., & Flower, D. R. 1991, J. Phys. B, 24, 2343
|
1 | dynamics.c | 1724 | get following to work
|
1 | h2_io.c | 1196 | add logic to deduce cs
|
1 | hmole_step.c | 590 | code below is inside loop over nd, but doesn't sum over nd, so hmi.rate_h2_allX_2_J0_grains
and hmi.rate_h2_ortho_para_conserve are determined only by last grain bin, is this OK ????
|
1 | lines_lv1_k_zn.c | 665 | this does not belong here - should be where radius incremnted
|
1 | prt_linepres.c | 61 | make this and eval rad pressure same routine, with flag saying to
print contributors - copy code from other routine - this code has been
left behind
|
1 | rt_escprob.c | 1035 | dynamics; this test assumes that neg vel are subsonic, so that sobolev length
would overestimate the optical depth, since ion is at most present over computed
slab, and possibly more.
|
1 | rt_escprob.c | 1160 | dynamics; this test assumes that neg vel are subsonic, so that sobolev length
would overestimate the optical depth, since ion is at most present over computed
slab, and possibly more.
|
1 | rt_line_one_tauinc.c | 31 | dynamics; this test assumes that neg vel are subsonic, so that sobolev length
would overestimate the optical depth, since ion is at most present over computed
slab, and possibly more.
|
2 | assertresults.c | 312 | NB this is not used, should do both, and more molecules (H2 only for now)
|
2 | atmdat_2photon.c | 366 | How should these affect locally emitted continuum calculated in rtdiffuse?
Just subtract these rates from the emitted ones?
|
2 | atmdat_readin.c | 936 | - check these
|
2 | atom_level3.c | 208 | test on c checks whether collisions are possible at this temperature,
should add photo excitation
|
2 | atom_level3.c | 219 | these pops ARE NOT defined below
|
2 | atom_oi.c | 217 | following needed to get badbugs/bug8.in to work
|
2 | atom_oi.c | 223 | following needed to get badbugs/bug5.in to work
|
2 | atom_oi.c | 408 | this must have all stimulated emission, pump by cont, etc
|
2 | atom_pop5.c | 246 | p(5) was very slightly negative (1e-40) for SII in dqher.in
|
2 | cddefines.c | 286 | do something with this or set to LONG_MAX?
after moving collapsed levels to iso.nCollapsed, this
variable does nothing.
iso.nTopOff[ipHE_LIKE] = 0;
|
2 | cddrive.c | 1673 | this should have a last argument like cdIonFrac for whether or not weighting
is wrt electron density
|
2 | cont_createmesh.c | 419 | consider making the fine opacity array a double. with a float, the opacity
itself often becomes a denormalized number, it then becomes significant when multiplied
by dr - can cause numerical noise. this is why the coarse opacity array is a double
|
2 | cont_createpointers.c | 1080 | what are we trying to print here?
|
2 | cont_createpointers.c | 465 | this is redundant with contents of oxygen line arrays
use them instead
when removing this, make sure all line intensity predictions
also go into oi line arrays
|
2 | cont_pump.c | 26 | if used, add damp as arg since calling routine probably evaluated it
|
2 | conv_base.c | 673 | this assert is not passed if error made much smaller. This
error should be related to a check on convergence of the molecular
networks and their sum rules, with a criteria used here and there
|
2 | coolcarb.c | 216 | add term for protons from Rouef, E., & Le Bourlot, J. 1990, A&A, 236, 515
|
2 | cooliron.c | 626 | following to stop insane FeX strengths
>>chng 96 jul 11, removed 1 10 factor, so using real data, 90.01
|
2 | cooliron.c | 78 | - ground term is actually a fix level system, the vectors are
created, with pointers ipFe1_54m , ipFe1_111m, must add collision date, use
larger model atom
|
2 | cooliron.c | 803 | update atomic data to Chidichimo et al 1999 AASup 137, 175
|
2 | cooliron.c | 825 | * following not in cooling function
|
2 | coolmagn.c | 191 | use AtomSeqBeryllium here
|
2 | coolneon.c | 129 | transfer these lines
|
2 | coolnitr.c | 73 | use atom_level3
|
2 | cooloxyg.c | 461 | put all these in cooling
|
2 | coolsili.c | 170 | - update to this reference for As
>>refer Si7 As Galavis, M.E., Mendoza, C., * Zeippen, C.J. 1997, A&AS, 123, 159
|
2 | dynamics.c | 143 | this should be setable at run time as per Robin Williams email
rshock = 4e16;
|
2 | dynamics.c | 1638 | Need to include divergence terms in pressure balance
if flux index is != 0
|
2 | dynamics.c | 1660 | Need to include divergence terms in pressure balance
if flux index is != 0
|
2 | dynamics.c | 414 | Switch to supersonic when bad enough failure for STRONGD --
need to improve this logic when the p(rho) data is cleaner
|
2 | gaunt.c | 137 | - These are liberal bounds, in final product, this
ASSERT should be much more demanding.
|
2 | gaunt.c | 154 | - insert reference
|
2 | gaunt.c | 288 | - insert reference
|
2 | gaunt.c | 339 | - this check may also too liberal.
|
2 | gaunt.c | 382 | - pick these interface values and stick with it...best results have been 0.4, 1.5
|
2 | grains.c | 1208 | should any of the following 3 statements be removed
|
2 | grains.c | 1546 | this algorithm might be more efficient with Brent
|
2 | grains.c | 1603 | use something like log(ThermRatio) + log(delta) ????
|
2 | grains.c | 2045 | remove gv.bin[nd]->lgChrgConverged, gv.bin[nd]->LowestPot, gv.bin[nd]->dstpotsav
gv.bin[nd]->RateUp, gv.bin[nd]->RateDn; also gv.HighestIon??, HighestIonStage()??
|
2 | grains.c | 2295 | note that the number of primary electrons is given by yhat,
which may not be one, so this is not necessarily consistent
|
2 | grains.c | 2297 | avAuger depends on grain charge, this should be treated explicitly here
|
2 | grains.c | 4322 | a self-consistent treatment for the heating by Auger electrons should be used
|
2 | grains.c | 4323 | a self-consistent treatment for the heating by Compton recoil electrons should be used
|
2 | grains.c | 4805 | a self-consistent treatment for the heating by Auger electrons should be used
|
2 | grains.c | 4806 | a self-consistent treatment for the heating by Compton recoil electrons should be used
|
2 | grains_mie.c | 1854 | impose size limits on PAH's, changeover to graphite ??
|
2 | grains_mie.c | 1855 | detect if PAH's are present in ionized regions ??
|
2 | grains_mie.c | 2026 | include code for interpolating inv_att_len somewhere!!
|
2 | grains_mie.c | 2027 | why is charge of pah2_ism_01.opc so different??
|
2 | h2.c | 2583 | this is factor for lya excit do something about this
|
2 | h2.c | 2711 | is this right - two rates that add together? or is
J=1 to 0 only added for 0,1 to 0,0?
|
2 | h2.c | 2873 | - did all gbar coll include test on spin changing? Also, this
does not have the back collision term
|
2 | h2.c | 3500 | - put H2Lines in outward beams in RT_diffuse
|
2 | h2.c | 3508 | put supra thermal excitation into excitation of electronic bands
|
2 | h2.c | 36 | put in excited molecular dissociation from v >=4 as in hazy 2
|
2 | heatsum.c | 580 | find correct high-energy limit for these
|
2 | helike.c | 1563 | this is part of the induce 2nu problem, which must be fixed for both
he and h sequences.
|
2 | helike.c | 1811 | - this structure is currently only used for helium itself...
stuff numbers in for other elements, or drop the [nelem] dimension off
of helike.HeCS
|
2 | helike.c | 2119 | fix this to go to much larger n
|
2 | helike.c | 213 | remove this when this routine really controls helium itself
|
2 | helike.c | 434 | This is not the best source of data. Replace it.
|
2 | helike.c | 754 | say where these come from...and do something with them!
|
2 | helikelevel.c | 1126 | put collisional errors into helike.Error array
|
2 | helikelevel.c | 416 | Can't be used for helium sequence because suprathermals rate has not been split up into
individual levels for helium sequence. So Secondaries structure must be extended to include
helium levels before the below code can be implemented. This is not a pressing correction
because total suprathermal is already included for the sequence, but this should not be put
off for too long because it should not be too difficult to do correctly.
|
2 | helikelevel.c | 436 | these are all wrong -- see comment above
|
2 | helikelevel.c | 822 | at the moment can only assert these for the atom, and for Vriens gbar.
|
2 | helike_cs.c | 180 | find ioniz rates for helium like species, these are hydrogenic rates
|
2 | helike_cs.c | 994 | Even spin-changing collisions are included here. Is this okay?
|
2 | helike_einsta.c | 340 | For now just just put 1% error for forbidden lines.
|
2 | helike_einsta.c | 738 | for now just give ions some a 5% error across the board
|
2 | helike_recom.c | 1234 | insert refer here.
|
2 | helike_recom.c | 1246 | put Burgess reference here
|
2 | helike_recom.c | 1317 | use a canned interpolation routine, no need for special one here
|
2 | helike_recom.c | 262 | check that these are okay
|
2 | helike_recom.c | 381 | is this good enough? Need some justification!
|
2 | hmole.c | 474 | following always true, why? either remove test or use it -
it is here to save time - this step routine is called very often
|
2 | hmole.c | 502 | this should be done with new populations after converged soln
|
2 | hmole_step.c | 1146 | process is net source term for H(n=3) states, must be added in
|
2 | hmole_step.c | 1170 | process is net ionization term for H(n=3) states
|
2 | hmole_step.c | 1630 | this rate drives numerical instability in such models as secondary1 and 2.in
|
2 | hmole_step.c | 1763 | must add process H2+ + H- => H2 + H, Dalgarno&Lepp 87
|
2 | hmole_step.c | 1768 | put in H2+ + gamma => H + H+
|
2 | hmole_step.c | 601 | - put in actual composition dependent Tad - this is only valid
for bare surfaces - not ice - for ice Tad is 555K
|
2 | hmole_step.c | 775 | check that this is really natural log, not base 10
|
2 | hydro_vs_rates.c | 252 | This routine, like the above one, needs to use proper energy.
|
2 | hydro_vs_rates.c | 306 | sometimes rate is negative...is that okay?
|
2 | ionoxyge.c | 117 | this will be zero in current form of atmdat_phfit
set 2s**2 rate to rate for O V
|
2 | ion_solver.c | 986 | renorm should == 1 when the molecules and
ionization are in equilibrium. Should monitor
this figure of merit in calling routine.
|
2 | iso_cool.c | 14 | - if pc lint ever fixes this bug in their product, remove this -e
|
2 | iso_cool.c | 80 | this routine dumps all heating and cooling into only a very few lables,
it would be best to break these out into individual labels that show element,
iso sequence, and agent
|
2 | iso_create.c | 525 | this will not work if highest level is resolved
|
2 | iso_photo.c | 110 | - hydro.lgHInducImp should depend on iso and nelem,
even better - just call one gamnc and within that code
check to see whether induced is important by looking
at occnum near threshold
|
2 | iter_startend.c | 104 | this does not belong here - move to where main data created
|
2 | lines_continuum.c | 50 | this block of lines should have nInu, InwT, InwC like main vector of continuum points
|
2 | lines_helium.c | 619 | - this structure is currently only used for helium itself...
stuff numbers in for other elements, or drop the [nelem] dimension off
of CaABLines
|
2 | lines_lv1_k_zn.c | 831 | put this line back in!
EFF = 43.6 (43.6 + 0.27*COLFAC)
|
2 | lines_lv1_k_zn.c | 900 | put this in
|
2 | lines_lv1_li_ne.c | 620 | these are actually in the optical depth arrays, should
be moved to call PutLine
|
2 | opacity_addtotal.c | 332 | update photoelectric opacity for H2 to include real cross sections and energies.
this is not a higher priority because when H2 is formed there can be very little ionizing
radiation. this process must be trivial compared with the solomon process
|
2 | opacity_createall.c | 1414 | update to astro-ph/0308073, Lee, H-W, ApJ in press
|
2 | pressuretotal.c | 119 | this is the molecular binding energy (?) not set to anything
|
2 | pressuretotal.c | 174 | - should this include mass in grains?
|
2 | prt_comment.c | 1464 | extend to all iso and elem
|
2 | punch_do.c | 2826 | - NB - if continuum resolution changed the lines WILL NOT WORK
|
2 | punch_special.c | 45 | this most likely needs to be changed in light of new 2nu treatment
|
2 | radius_next.c | 6 | - this routine is very important since it sets the pace for the calculation,
and directly affects the convergence of the code. Most of the logic is very old and
messy.
1) make sure all test cases have punch dr
2) cat all these reasons together into one file and sort on the reason
3) discover what logic is the main pacesetter for the code
4) which are never triggered and so can be removed
|
2 | rt_diffuse.c | 125 | This doesn't really seem to be the expression above!!!
|
2 | rt_diffuse.c | 393 | should use ConEmitLocal for all continua, but not followed
by ThrowOut - put that at the end. Once continua all
bundled this way, it will be easy to save them as a function
of depth and then do exact rt
|
2 | rt_diffuse.c | 455 | Replace this constant with the appropriate macro, if any
|
2 | rt_diffuse.c | 624 | add fegrain to outward beams, but within main formalism by including grains
in all x-ray processes
|
2 | rt_escprob.c | 901 | this min is because there are no calculations that show what to do
for beta beyound this value
|
2 | rt_line_one.c | 675 | - consider using ipDEST_INCOM instead of K2, it is much faster
|
2 | rt_stark.c | 64 | - Stark is disabled for now since Lya escape causes density dependent
feedback on the radiative transfer. Would need to redo the escape
probs every time the electron density is updated - see blr89.in for an
example
|
2 | zero.c | 1427 | why are higher lyman lines (ipResoRedist) not same as
for H-like?
|
2 | zero.c | 375 | change this to CS_new
|
2 | zero.c | 929 | file opacities are disabled for now - reinstate this when arrays settle down
|
3 | coolcarb.c | 257 | change to atom_level3
|