This is a table of the list of TODO used in CLOUDY source files and the comments following them. Table from data in 'tabledtodo.txt'
Priority Filename Line number Comment
1coolcarb.c209add neutral helium Staemmler, V., & Flower, D. R. 1991, J. Phys. B, 24, 2343
2assertresults.c312NB this is not used, should do both, and more molecules (H2 only for now)
2atmdat_2photon.c368How should these affect locally emitted continuum calculated in rtdiffuse? Just subtract these rates from the emitted ones?
2atmdat_readin.c936- check these
2atom_level3.c208test on c checks whether collisions are possible at this temperature, should add photo excitation
2atom_level3.c219these pops ARE NOT defined below
2atom_oi.c217following needed to get badbugs/bug8.in to work
2atom_oi.c223following needed to get badbugs/bug5.in to work
2atom_oi.c409this must have all stimulated emission, pump by cont, etc
2atom_pop5.c246p(5) was very slightly negative (1e-40) for SII in dqher.in
2cddefines.c313do something with this or set to LONG_MAX? after moving collapsed levels to iso.nCollapsed, this variable does nothing. iso.nTopOff[ipHE_LIKE] = 0;
2cddrive.c1619this should have a last argument like cdIonFrac for whether or not weighting is wrt electron density
2co.c1537- update dates to this reference
2co.c1551- check this - the following two almost certainly should be to CO+
2cont_createmesh.c417consider making the fine opacity array a double. with a float, the opacity itself often becomes a denormalized number, it then becomes significant when multiplied by dr - can cause numerical noise. this is why the coarse opacity array is a double
2cont_createpointers.c1079what are we trying to print here?
2cont_createpointers.c464this is redundant with contents of oxygen line arrays use them instead when removing this, make sure all line intensity predictions also go into oi line arrays
2cont_pump.c26if used, add damp as arg since calling routine probably evaluated it
2conv_ionizeopacitydo.c551this assert is not passed if error made much smaller. This error should be related to a check on convergence of the molecular networks and their sum rules, with a criteria used here and there
2coolcarb.c208add term for protons from Rouef, E., & Le Bourlot, J. 1990, A&A, 236, 515
2cooliron.c659following to stop insane FeX strengths >>chng 96 jul 11, removed 1 10 factor, so using real data, 90.01
2cooliron.c73- ground term is actually a fix level system, the vectors are created, with pointers ipFe1_54m , ipFe1_111m, must add collision date, use larger model atom
2cooliron.c836update atomic data to Chidichimo et al 1999 AASup 137, 175
2cooliron.c858 * following not in cooling function
2coolmagn.c191use AtomSeqBeryllium here
2coolneon.c129transfer these lines
2coolnitr.c73use atom_level3
2cooloxyg.c441put all these in cooling
2coolsili.c165- update to this reference for As >>refer Si7 As Galavis, M.E., Mendoza, C., * Zeippen, C.J. 1997, A&AS, 123, 159
2coolsili.c37- rm these calls to temp to a pow
2dynamics.c140this should be setable at run time as per Robin Williams emailrshock = 4e16;
2dynamics.c1563Need to include divergence terms in pressure balance if flux index is != 0
2dynamics.c1585Need to include divergence terms in pressure balance if flux index is != 0
2dynamics.c1648rm this line
2dynamics.c1654line radiation pressure is currently not turned on - should be
2dynamics.c186- this should be setable at run time as per Robin Williams email
2dynamics.c362Switch to supersonic when bad enough failure for STRONGD -- need to improve this logic when the p(rho) data is cleaner
2gaunt.c137- These are liberal bounds, in final product, this ASSERT should be much more demanding.
2gaunt.c154- insert reference
2gaunt.c288- insert reference
2gaunt.c339- this check may also too liberal.
2gaunt.c382- pick these interface values and stick with it...best results have been 0.4, 1.5
2grains.c2281note that the number of primary electrons is given by yhat, which may not be one, so this is not necessarily consistent
2grains.c2283avAuger depends on grain charge, this should be treated explicitly here
2grains.c2957introduce structures like gv.bin[nd]->chrg[nz]->DustZ this routine than simply has to swap structures instead of copying them element by element, this is faster, but more importantly safer !
2grains.c4269a self-consistent treatment for the heating by Auger electrons should be used
2grains.c4270a self-consistent treatment for the heating by Compton recoil electrons should be used
2grains_mie.c1866impose size limits on PAH's, changeover to graphite ??
2grains_mie.c1867detect if PAH's are present in ionized regions ??
2grains_mie.c2038include code for interpolating inv_att_len somewhere!!
2grains_mie.c2039why is charge of pah2_ism_01.opc so different??
2h2.c1453what happens if this loop does not include excited elec states?
2h2.c1796is this right - two rates that add together? or is J=1 to 0 only added for 0,1 to 0,0?
2h2.c1947- did all gbar coll include test on spin changing? Also, this does not have the back collision term
2h2.c2314- put H2Lines in outward beams in RT_diffuse
2h2.c2328put supra thermal excitation into excitation of electronic bands
2h2.c36put in excited molecular dissociation from v >=4 as in hazy 2
2helike.c2127say where these come from...and do something with them!
2helike.c3679- this structure is currently only used for helium itself... stuff numbers in for other elements, or drop the [nelem] dimension off of helike.HeCS
2helike.c4132insert refer here.
2helike.c4144put Burgess reference here
2helike.c4365find ioniz rates for helium like species, these are hydrogenic rates
2helike.c478remove this when this routine really controls helium itself
2helike.c629finish this reference. This will give quasi-real energies for all transitions, allowing a reasonable determination of which decays are zeroed due to being below the plasma frequency. The 1nelem dependence is arbitray.
2helike.c662This is not the best source of data. Replace it.
2helikelevel.c476all of this 2nu stuff should be treated with an error.
2helikelevel.c846fixit(); some lines had strong masers, quench for now
2helikelevel.c878only done for helium currently...leave or apply to ions?
2helikelevel.c895at the moment can only assert these for the atom, and for Vriens gbar.
2helikelevel.c899try to assert this for n=3 and possibly n=2 as well
2helike_cs.c118Replace this constant with the appropriate macro.
2helike_cs.c52should the 0.001 really be there?
2helike_cs.c53why is this not 8kT/(PI*mu) instead of 2kT/mu? See Lang, Astro. Quantities pg 212.
2helike_cs.c689Even spin-changing collisions are included here. Is this okay?
2hmole.c1326process is net source term for H(n=3) states, must be added in
2hmole.c1350process is net ionization term for H(n=3) states
2hmole.c1753this rate drives numerical instability in such models as secondary1 and 2.in
2hmole.c1879must add process H2+ + H- => H2 + H, Dalgarno&Lepp 87
2hmole.c1884put in H2+ + gamma => H + H+
2hmole.c2502Check dynamics treatment update to new formalism
2hmole.c2701This switches fixup off for dynamics -- can't just scale bvec in this case
2hmole.c585following always true, why? either remove test or use it - it is here to save time - this step routine is called very often
2hmole.c796understand how this relates to Draine & Sutin equation
2hmole.c880- put in actual composition dependent Tad - this is only valid for bare surfaces - not ice - for ice Tad is 555K
2hydro_vs_rates.c252This routine, like the above one, needs to use proper energy.
2hydro_vs_rates.c306sometimes rate is negative...is that okay?
2ionoxyge.c116this will be zero in current form of atmdat_phfit set 2s**2 rate to rate for O V
2ion_solver.c382clean this up - lgTriDian is always true, and most of rest is if 0
2ion_solver.c539dense.xIonDense[nelem][] should be set to default values before this ...
2ion_solver.c572norm should == 1 when the molecules and ionization are in equilibrium. Should monitor this figure of merit in calling routine.
2ion_solver.c76remove this block when hmole is fully functional
2iso_cool.c16- if pc lint ever fixes this bug in their product, remove this -e
2iso_cool.c83this routine dumps all heating and cooling into only a very few lables, it would be best to break these out into individual labels that show element, iso sequence, and agent
2iso_create.c539this will not work if highest level is resolved
2iso_photo.c110- hydro.lgHInducImp should depend on iso and nelem, even better - just call one gamnc and within that code check to see whether induced is important by looking at occnum near threshold
2lines_continuum.c50this block of lines should have nInu, InwT, InwC like main vector of continuum points
2lines_helium.c537- this structure is currently only used for helium itself... stuff numbers in for other elements, or drop the [nelem] dimension off of CaABLines
2lines_lv1_k_zn.c843put this line back in! EFF = 43.6 (43.6 + 0.27*COLFAC)
2lines_lv1_k_zn.c912put this in
2lines_lv1_li_ne.c621 these are actually in the optical depth arrays, should be moved to call PutLine
2opacity_createall.c1407update to astro-ph/0308073, Lee, H-W, ApJ in press
2physconst.h189this should be defined in terms of fundamentals...just not sure what they are!
2pressuretotal.c118this is the molecular binding energy (?) not set to anything
2pressuretotal.c177- this should include mass in grains
2prt_comment.c1436extend to all iso and elem
2prt_comment.c788- should implement similar test for new grains
2punch_do.c2474- NB - if continuum resolution changed the lines WILL NOT WORK
2punch_do.c3035this most likely needs to be changed in light of new 2nu treatment
2radius_next.c7- this routine is very important since it sets the pace for the calculation, and directly affects the convergence of the code. Most of the logic is very old and messy. 1) make sure all test cases have punch dr 2) cat all these reasons together into one file and sort on the reason 3) discover what logic is the main pacesetter for the code 4) which are never triggered and so can be removed
2rt_diffuse.c110This doesn't really seem to be the expression above!!!
2rt_diffuse.c378should use ConEmitLocal for all continua, but not followed by ThrowOut - put that at the end. Once continua all bundled this way, it will be easy to save them as a function of depth and then do exact rt
2rt_diffuse.c440Replace this constant with the appropriate macro, if any
2rt_diffuse.c739add fegrain to outward beams, but within main formalism by including grains in all x-ray processes
2rt_line_one.c623- consider using ipDEST_INCOM instead of K2, it is much faster
2rt_line_one_tauinc.c43this probably should be removed
2rt_stark.c64- Stark is disabled for now since Lya escape causes density dependent feedback on the radiative transfer. Would need to redo the escape probs every time the electron density is updated - see blr89.in for an example
2rt_tau_reset.c72add helium like series, checking on Lya
2startenditer.c102this does not belong here - more to where main data created
2zero.c1284why are higher lyman lines (ipResoRedist) not same as for H-like?
2zero.c358change this to CS_new
2zero.c820file opacities are disabled for now - reinstate this when arrays settle down
3coolcarb.c246change to atom_level3